Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #249: upgrade parse-github-url v1.0.3 #289

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

JHyeok
Copy link
Contributor

@JHyeok JHyeok commented Aug 12, 2024

Fixes #249

This error occurred when using parse-github-url v1.0.2 in a Node.js 20 environment, and the issue was resolved by upgrading parse-github-url to v1.0.3.

In Node.js 20, when using parse-github-url version 1.0.2, an error occurs when running based on the following SSH address.

npm install -g parse-github-url@1.0.2
parse-github-url git@github.com:cookpete/auto-changelog.git
(node:5774) [DEP0170] DeprecationWarning: The URL http://git@github.com:cookpete/auto-changelog.git is invalid. Future versions of Node.js will throw an error.
(Use `node --trace-deprecation ...` to show where the warning was created)

In parse-github-url v1.0.3, this issue has been resolved.

@cookpete cookpete merged commit 3444e49 into cookpete:master Sep 11, 2024
@ljharb
Copy link
Contributor

ljharb commented Sep 11, 2024

this is fine, but due to semver isn't actually needed.

@JHyeok
Copy link
Contributor Author

JHyeok commented Sep 12, 2024

@ljharb
Thank you, but there was a yarn.lock file in the project, and the version was locked.
if the yarn.lock file were removed and reinstalled, then it seems like you're right, and this PR would be unnecessary

@ljharb
Copy link
Contributor

ljharb commented Sep 12, 2024

@JHyeok still would be, because yarn.lock files are dev-only - they don't affect consumers whatsoever.

@JHyeok
Copy link
Contributor Author

JHyeok commented Sep 12, 2024

@ljharb
Ah, now I understand your answer. I was being silly. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError [ERR_INVALID_URL]: Invalid URL
3 participants