Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YouTube Videos Not Forwarding end Param #419

Closed
relztic opened this issue Jun 6, 2018 · 1 comment
Closed

YouTube Videos Not Forwarding end Param #419

relztic opened this issue Jun 6, 2018 · 1 comment

Comments

@relztic
Copy link
Contributor

relztic commented Jun 6, 2018 •
edited
Loading

Affects Version

v1.6.3

User Story

When rendering a YouTube player, the end param is omitted on the embedded URL.

This preventing users to specify a range on a video...

e.g.: https://www.youtube.com/embed/tgbNymZ7vqY?start=100&end=110

References:

Conditions of Satisfaction

Specifying ranges on a YouTube video should preserve both the start and end params.
relztic added a commit to relztic/react-player that referenced this issue Jun 6, 2018
@relztic
(cookpete#419) YouTube videos not forwarding end param
e8362ff
@relztic relztic mentioned this issue Jun 6, 2018
Merged
@cookpete
Copy link
Owner

cookpete commented Jun 7, 2018

Sorted in 1.6.4

@cookpete cookpete closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @relztic