Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with version 2.1 trying to run simple example #902

Closed
RusseII opened this issue May 28, 2020 · 2 comments
Closed

Issues with version 2.1 trying to run simple example #902

RusseII opened this issue May 28, 2020 · 2 comments

Comments

@RusseII
Copy link

RusseII commented May 28, 2020

https://codesandbox.io/s/intelligent-darwin-rfw03?file=/src/App.js

image
@RusseII
Copy link
Author

RusseII commented May 28, 2020

Works when I downgrade the version to 2.01

@cookpete
Copy link
Owner

2.1.0 uses import() statements for lazy loading players. Seems like codesandbox doesn't handle them very well.

Relevant issues:

Not an ideal solution but I guess it would work if you used the built file in dist instead? eg:

https://unpkg.com/react-player@2.1.0/dist/ReactPlayer.js

cookpete added a commit that referenced this issue Jun 7, 2020
@cookpete
Move lazy loading players to react-player/lazy
2d4f368 
Fixes #912
Fixes #907
Fixes #865
Sort of fixes #910
Sort of fixes #902
Affects #886
Affects #738
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Move lazy loading players to react-player/lazy
96f435c 
Fixes cookpete/react-player#912
Fixes cookpete/react-player#907
Fixes cookpete/react-player#865
Sort of fixes cookpete/react-player#910
Sort of fixes cookpete/react-player#902
Affects cookpete/react-player#886
Affects cookpete/react-player#738
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Move lazy loading players to react-player/lazy
975ff0e 
Fixes cookpete/react-player#912
Fixes cookpete/react-player#907
Fixes cookpete/react-player#865
Sort of fixes cookpete/react-player#910
Sort of fixes cookpete/react-player#902
Affects cookpete/react-player#886
Affects cookpete/react-player#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @RusseII