Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
hidden
is a standard HTML prop of react. I was building a toggle feature to hide ReactPlayer -- as opposed to re-rendering the player each toggle, which would lag due to having to retrieve and re-embed the media each time -- and found that ReactPlayer does not accept a hidden prop to hide its top level div. In order to hide it usinghidden
, I had to write another parent div above ReactPlayer just to hide the component.Changes Proposed:
I'd like to propose that
hidden
be added to one of the standard props ReactPlayer accepts (alongside the standardstyle
&className
props). Like so:I've included working code that allows this very use case in this PR. I've also included a line to the
Props
documentation in README.md abouthidden
as a prop that can hide ReactPlayer.