Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media attribute to source tag in file player #1269

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add media attribute to source tag in file player #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/players/FilePlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,14 +343,16 @@ test('render - string array', t => {

test('render - object array', t => {
const url = [
{ src: 'file.mp4', type: 'video/mp4', media: '(max-width:800px)' },
{ src: 'file.mp4', type: 'video/mp4' },
{ src: 'file.ogg', type: 'video/ogg' }
]
const wrapper = shallow(<FilePlayer url={url} config={config} />)
t.true(wrapper.containsMatchingElement(
<video src={undefined}>
{[
<source key={0} src='file.mp4' type='video/mp4' />,
<source key={0} src='file.mp4' type='video/mp4' media='(max-width:800px)' />,
<source key={1} src='file.mp4' type='video/mp4' />,
<source key={1} src='file.ogg' type='video/ogg' />
]}
{[]}
Expand Down
3 changes: 2 additions & 1 deletion types/base.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import { Component, ReactElement, CSSProperties } from 'react'
import ReactPlayer from './lib'

interface SourceProps {
media?: string
src: string
type: string
type?: string
}

export interface BaseReactPlayerProps {
Expand Down