Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make facebook config type properties optional #1314

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

samcarton
Copy link
Contributor

Fix for the below issue when using react-player facebook config in typescript

Current Behavior

  • Using react-player with typescript
  • when trying to pass facebook config the type definitions require all config fields.
  • Typescript flags it as an error if you just try to pass one prop e.g. appId.

Expected Behavior

Should be able to configure as per the sample in the docs:

<ReactPlayer
  url={url}
  config={{
    youtube: {
      playerVars: { showinfo: 1 }
    },
    facebook: {
      appId: '12345'
    }
  }}
/>

@cookpete cookpete merged commit a3134f9 into cookpete:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants