Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a file dist/ReactPlayer.standalone-module.js ES6 module #1425

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

pikilon
Copy link
Contributor

@pikilon pikilon commented Mar 27, 2022

A simple script to import renderReactPlayer as an ES6 module instead of polluting the global scope.

@pikilon pikilon force-pushed the feature/standalone-es6-module branch 2 times, most recently from 4b1cc3b to 27a169e Compare March 27, 2022 19:23
@cookpete cookpete merged commit e172ca0 into cookpete:master Jul 17, 2022
@pikilon
Copy link
Contributor Author

pikilon commented Jul 17, 2022

I'm 45, it is my first commit in a repository I use.
Very happy about it

@cookpete
Copy link
Owner

Nice job @pikilon! It’s never too late 😄

@cookpete
Copy link
Owner

Published in 2.11.0. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants