Fix #1604 - FilePlayer does not work if I passed an array of urls #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having a hard time importing this PR w/ this fix into my project, is there an ETA on this PR being merged in? |
nam-diijam
approved these changes
Jun 15, 2023
…urls PR cookpete#1538 was setting the src of the video element to undefined. Because of this, even if the users passed an array of urls, the video element would not play becuase it got a `src` of `undefined`; After fixing the undefined `src` issue, another PR was making a infinite loop issue when user passed an array of urls. There, the author set the `srcObject` to null. There as well, a check for `url` prop was missing. This PR aims to fix both of these overlooked aspects.
cookpete
force-pushed
the
fix-1604/array-of-urls-not-working
branch
from
2d66d6e
to
0f145ed
Compare
|
I think #1648 has fixed most of what this PR was doing, apart from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix FilePlayer does not work if I passed an array of urls #1604
PR #1538 was setting the src of the video element to undefined. Because of this, even if the users passed an array of urls, the video element would not play because it got an
srcofundefined;After fixing the undefined
srcissue, another PR was making an infinite loop issue when the user passed an array of URLs. There, the author set thesrcObjectto null. There as well, a check forurlprop was missing.This PR aims to fix both of these overlooked aspects.