-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override default webpack hashing algo #1664
Conversation
Since we don't want to require that the `node` binary be built against OpenSSL 3 (as it narrows down our supported ENVs matrix substantially) we had several options: - set `NODE_OPTIONS="--openssl-legacy-provider"` - override default webpack hasing algo I went with the latter because: a. MD4 is rubbish anyways b. NodeJS 16 does not recognise the --openssl-legacy-provider option and so, if set, the build fails.
Awesome, thanks @jessp01. Is it necessary to check in the dist/ builds with this change? It's causing a merge conflict and the contributing guide says you generally shouldn't. |
Hi @heff , Since looking through the diffs of these minimised files will no doubt prove to be painful and seeing how the build and tests all passed, I reckon it'd be safe to simply override the existing files but I leave the decision to you, of course. |
Updating the https://github.com/cookpete/react-player/blob/master/CONTRIBUTING.md#dist-files |
Hi @cookpete , Shall we add these to |
thanks for the contribution! with this larger refactor it's not an issue anymore. closed by #1684 |
Hi @luwes , This bit is still relevant: https://github.com/cookpete/react-player/pull/1664/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR12 Cheers, |
This is submitted as a follow-up to this pull: #1654
See https://nodejs.org/en/blog/release/v17.0.0#openssl-30
Since we don't want to require that the
node
binary be built against OpenSSL 3 (as it narrows down our supported ENVs matrix substantially) we had several options:NODE_OPTIONS="--openssl-legacy-provider"
I went with the latter because:
a. MD4 is rubbish anyways
b. NodeJS 16 does not recognise the
--openssl-legacy-provider
option and so, if set, the build fails with it