Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make force disabling PIP dependent on prop #964

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Jul 7, 2020

This is a great library and thank you for creating and maintaining it @cookpete . I was stoked to see that the library has support PIP but it feels a bit backwards to disable/remove pip when video is unmounted when most of the time, PIP is intended to be fired when the video is not explicitly visible and other content is given priority. However, as the library owner, I fully respect your decision to implement the UX you think is right for the library. So, this PR does not override the behavior you've implemented and adds a new prop to opt-in for that as a feature.

@cookpete
Copy link
Owner

Hey @foysalit, thanks for the PR.

I like the idea but I've made it a more generic stopOnUnmount prop that defaults to true, so you can use

pip={true} stopOnUnmount={false}

@cookpete cookpete merged commit 5804bfb into cookpete:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants