Make force disabling PIP dependent on prop #964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great library and thank you for creating and maintaining it @cookpete . I was stoked to see that the library has support PIP but it feels a bit backwards to disable/remove pip when video is unmounted when most of the time, PIP is intended to be fired when the video is not explicitly visible and other content is given priority. However, as the library owner, I fully respect your decision to implement the UX you think is right for the library. So, this PR does not override the behavior you've implemented and adds a new prop to opt-in for that as a feature.