Fix invalid docker version check #4169

easilok · 2024-11-07T22:17:01Z

Changes

Add proper error information on server docker version validation;
Update minimum docker version checks to match current installation version (26).
Opted to reuse current config value for the server docker version check, to improve re-usability;
Injected minimum docker version ok frontend for onboarding page and server validation checks.

app/Livewire/Server/ValidateAndInstall.php

peaklabs-dev · 2024-11-12T12:21:01Z

Thank you for the PR 💜. I will fix some things with the constant but overall looks good.

easilok · 2024-11-12T16:53:37Z

Thank you for the PR 💜. I will fix some things with the constant but overall looks good.

Thank you and I hope to contribute again.

peaklabs-dev · 2024-11-12T20:33:59Z

I look forward to your next contribution.

easilok added 2 commits November 5, 2024 13:23

add feedback on docker version check failure

752ae4a

update docker minimum version to 26

3fe636a

easilok force-pushed the fix-invalid-docker-version-check branch from 07e422a to 9867b8e Compare November 7, 2024 22:22

easilok commented Nov 7, 2024

View reviewed changes

app/Livewire/Server/ValidateAndInstall.php Outdated Show resolved Hide resolved

peaklabs-dev self-assigned this Nov 8, 2024

using docker version constant as user feedback

770163d

easilok force-pushed the fix-invalid-docker-version-check branch from 9867b8e to 770163d Compare November 10, 2024 21:28

validating minimum docker version with less that

ee2b957

easilok requested a review from peaklabs-dev November 10, 2024 22:09

peaklabs-dev approved these changes Nov 12, 2024

View reviewed changes

peaklabs-dev merged commit 0ce2fbf into coollabsio:next Nov 12, 2024
1 check passed

github-actions bot unassigned peaklabs-dev Nov 12, 2024

easilok deleted the fix-invalid-docker-version-check branch November 12, 2024 16:52

github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024