Vine: Cleanup resource accounting #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthain
added
cleanup
All uses of largest safely replaced by total.
Removed unused total_resources_last.
dthain
force-pushed
the
vine-cleanup-resources
branch
from
3754234 to
271994e
Compare
Jbrocket
pushed a commit
to Jbrocket/cctools
that referenced
this pull request
Sep 11, 2023
* Squelch misleading debug message about library sending. * Remove smallest/largest fields from vine_resources. All uses of largest safely replaced by total. * lint * Simplify intake of resources -- just set total and leave inuse alone. * Remove phantom coprocess function * Remove extern link to total_resources, keep integer count locally. * Removed local_resources in favor of total_resources. Removed unused total_resources_last. * Format * Compute mins and maxes of resources when reporting status. * Bump vine protocol to reflect change in resource messages. * Remove old terms: ds_worker -> worker * Fixed missing instance of largest on rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vine_resourcehad vestigial fieldslargestandsmallestthat were a holdover from the WQ foreman and resulted in confusing debug output.