Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dask vine: Report to catalog on end of processing graph #3765

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

btovar
Copy link
Member

@btovar btovar commented Apr 15, 2024

When the dask executor finished the graph, now it will update the catalog info. Before, the info will not be updated if the manager was run inside a notebook (i.e., no further m.wait calls), which was confusing when running vine_status

Post-change actions

Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Did you update the manual to reflect your changes, if appropriate? This action should be done after your changes are approved but not merged.
  • Type Labels Select github labels for the type of this change: bug, enhancement, etc.
  • Product Labels Select github labels for the product affected: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

Additional comments

This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.

@btovar btovar force-pushed the report_to_manager branch from beab365 to 14ce2c1 Compare April 15, 2024 16:15
@btovar btovar changed the title dask vine: Report to manager on processing graph dask vine: Report to catalog on end of processing graph Apr 15, 2024
@btovar btovar merged commit 92b2c60 into cooperative-computing-lab:master Apr 16, 2024
7 checks passed
@btovar btovar deleted the report_to_manager branch April 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants