vine: Worker contact address #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump the protocol version, please |
dthain
requested changes
Apr 16, 2024
dthain
approved these changes
Apr 17, 2024
btovar
added a commit
that referenced
this pull request
Apr 17, 2024
* vine worker: add --contact-address to set arbitrary peer server * vine: fix bug, function needs peer struct, not source name * vine: keep explicit transfer address * vine: rewrite f->source as needed * rename to --transfer-address for consistency * fix bugs: w->transfer_port_active not set and not checked * increase protocol version * vine: worker:// to workerip:// to actually to the rewrite... * adds address_is_valid_ip * addr to hostport, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit --transfer-address to vine worker. If given, manager does nothing to the address. worker urls are now
workerip://andworker://. Ifworker://, then on get, the worker does a name resolution.Post-change actions
Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.Additional comments
This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.