Add Robust Error Checking to Library and Worker's Communication Patterns #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphung3
changed the title
dthain
requested changes
Nov 8, 2024
btovar
requested changes
Nov 18, 2024
btovar
approved these changes
Nov 21, 2024
|
ready to merge? |
|
Yep. It's RTM. |
btovar
pushed a commit
that referenced
this pull request
Dec 14, 2024
…rns (#3974) * scheduling with library protocol version checked * add check exec_mode of library to worker * fix bug * fix bug 2 * fix jx lookup int * format code * add doc * remove conversion from int * remove library version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces more error checking in the worker when a library first starts up. A worker now sanity-checks a library's name, task_id, and exec_mode instead of just the library's name.
A new library protocol number is also added and should be incremented every time the library changes its communication pattern with the worker.
Issue: #3439.
Merge Checklist
The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.