fix double reap of tasks on app failure #4000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthain
approved these changes
Dec 6, 2024
JinZhou5042
approved these changes
Dec 6, 2024
btovar
force-pushed
the
fix_double_reap
branch
2 times, most recently
from
bfa16a8 to
962541b
Compare
btovar
force-pushed
the
fix_double_reap
branch
from
e4d3a1f to
694ceef
Compare
|
Odd build failures on this one, is it just a transient issue? The bug is a serious one, so it would be good to get the fix deployed soon. |
|
I agree! A simpler hot fix has been merged already (#4002). I'm trying to figure out why it fails in the docker CI but not locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JinZhou5042, this is related to the fix you did for
&=.@colinthomas-z80, this is fix I was talking about that might be hiding why you tasks get stuck.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.