[FIX] easy_my_coop: Fix name computation crash

Don't use value from self when looping over a list Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
coopiteasy · Jun 15, 2022 · ab75fd1 · ab75fd1
1 parent 0c18cae
commit ab75fd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/easy_my_coop/models/subscription_request.py b/easy_my_coop/models/subscription_request.py
@@ -147,7 +147,7 @@ def check_iban(self, iban):
     def _compute_name(self):
         for sub_request in self:
             sub_request.name = " ".join(
-                part for part in (self.firstname, self.lastname) if part
+                part for part in (sub_request.firstname, sub_request.lastname) if part
             )
 
     @api.multi

diff --git a/easy_my_coop/readme/newsfragments/330.bugfix.rst b/easy_my_coop/readme/newsfragments/330.bugfix.rst
@@ -0,0 +1 @@
+Fix name computation crash