Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatic Draft Release Creator; Reusable Workflow #52

Closed
wants to merge 14 commits into from

Conversation

arunpoudel
Copy link
Contributor

@arunpoudel arunpoudel commented Oct 9, 2023

Why

See

Changes

Features:

  • added callable workflow that creates a draft release on pr. Sample

Docs:

  • Updated README on how to use release-drafter workflow
  • Added docs/index.md explaining how it works.

Summary

This change introduces a new workflow that can be used to create automatic draft releases when a PR is created. Although it was originally only intended to be used by go, this can be used by other projects as well as is, if we do not introduce additional go related version enforcements into this workflow.

Reflection

As gorelease looked abandoned, I decided not to include it in this implementation.

For better suggestion on labels, we can also add (this)[https://github.com/bobg/modver] which will definitely solve(or maybe minimize, if not solve) our problem of reliance on github PR title and human action needed to correctly label PRs.

It has been intentionally designed and develop so that a human can always intervene and change the generation(be it labels or the draft PR). This is done so that we have some flexibility and control over versioning while still having helpers that will make works easier and faster.

Some other tools to investigate in future would be:

Resolves https://github.com/coopnorge/engineering-issues/issues/325

@arunpoudel arunpoudel marked this pull request as ready for review October 11, 2023 07:43
@arunpoudel arunpoudel requested a review from a team as a code owner October 11, 2023 07:43
Copy link
Member

@nhhagen nhhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunpoudel this implementation should be moved to its own repository. The workflows in here should have been extracted into their own repos. This allows us to individually version workflows.

All our current workflows: https://github.com/orgs/coopnorge/repositories?q=github-workflow-&type=all&language=&sort=

See GitHub reusable workflows and actions for more information about setting up new reusable workflows.

arunpoudel added a commit to coopnorge/github-workflow-release-drafter that referenced this pull request Oct 12, 2023
This implements automatic draft release creator reusable workflow. [See](coopnorge/engineering-github-actions#52) for more details.
@arunpoudel
Copy link
Contributor Author

Closing this PR as it has been moved here.

@arunpoudel arunpoudel closed this Oct 12, 2023
@arunpoudel arunpoudel deleted the auto-release-workflow branch October 12, 2023 07:42
arunpoudel added a commit to coopnorge/github-workflow-release-drafter that referenced this pull request Oct 13, 2023
This implements automatic draft release creator reusable workflow. [See](coopnorge/engineering-github-actions#52) for more details.

Resolves coopnorge/engineering-issues#325
arunpoudel added a commit to coopnorge/github-workflow-release-drafter that referenced this pull request Oct 16, 2023
* feat: Automatic Draft Release Creator

This implements automatic draft release creator reusable workflow. [See](coopnorge/engineering-github-actions#52) for more details.

Resolves coopnorge/engineering-issues#325

* doc: added a para about how go release drafter works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants