Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package versions #2990

Merged
merged 4 commits into from
Sep 25, 2023
Merged

fix package versions #2990

merged 4 commits into from
Sep 25, 2023

Conversation

WeberJulian
Copy link
Contributor

No description provided.

@akx
Copy link
Contributor

akx commented Sep 25, 2023

I don't think it's a great idea to lock every version down to patch version level... I'm noticing my PRs are fervently trying to compile scikit-learn from scratch, it might be a better idea to just figure out why that is and fix that alone?

@WeberJulian WeberJulian requested a review from erogol September 25, 2023 12:59
@WeberJulian
Copy link
Contributor Author

@akx I've lowered the versions constrained using the * operator, but fixing has two main advantages: 1- the CI/install stop breaking without apparent reason because of an external package release. 2- Stricter versions makes the install significantly faster because it makes the task of the solver easier. What's your reasoning about not fixing the versions? Security concerns?

@akx
Copy link
Contributor

akx commented Sep 25, 2023

If one was to try and use TTS as a library/dependency with tightly narrowed versions, they might easily end up in a situation where their other dependencies cause an unresolvable situation.

If TTS is never imagined to be used as a library (or a dependency for any other project at large) then it's not a concern.

@akx
Copy link
Contributor

akx commented Sep 25, 2023

Also, it might be a good idea to think about making more of the per-model dependencies extras but that's probably out of scope for this PR.

@erogol erogol merged commit 359755c into dev Sep 25, 2023
44 checks passed
@erogol erogol deleted the fix-TTS-install branch September 25, 2023 16:10
@akx akx mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants