Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (save best model after 0 steps in tests) #3423

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix CI (save best model after 0 steps in tests) #3423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc09921
Fix aux unit tests
Edresson Dec 6, 2023
9f325b1
fixup! Fix aux unit tests
eginhard Dec 8, 2023
99fee6f
build: use Trainer>=0.0.36
eginhard Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TTS/bin/train_encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def evaluation(model, criterion, data_loader, global_step):

def train(model, optimizer, scheduler, criterion, data_loader, eval_data_loader, global_step):
model.train()
best_loss = float("inf")
best_loss = {"train_loss": None, "eval_loss": float("inf")}
avg_loader_time = 0
end_time = time.time()
for epoch in range(c.epochs):
Expand Down Expand Up @@ -248,7 +248,7 @@ def train(model, optimizer, scheduler, criterion, data_loader, eval_data_loader,
)
# save the best checkpoint
best_loss = save_best_model(
eval_loss,
{"train_loss": None, "eval_loss": eval_loss},
best_loss,
c,
model,
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pandas>=1.4,<2.0
# deps for training
matplotlib>=3.7.0
# coqui stack
trainer>=0.0.32
trainer>=0.0.36
# config management
coqpit>=0.0.16
# chinese g2p deps
Expand Down
Loading