Add JSON request support to server.py #3528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n request body with your text and will allow for longer texts that otherwise exceed the maximum http url length
|
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
|
Rip, I hope somehow open source contributions can still happen to this project |
|
I have created a fork of TTS, incorporating all the valid pending pull requests. You can find it at https://github.com/davidmartinrius/TTS/ |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently the server only supports generating TTS from text and settings set in either query params or headers. This means that for larger amounts of text, the query params can go over the maximum allowed length of an HTTP uri.
Solution
Allowing the /api/tts endpoint to accept text and settings from the request body as well would be useful to avoid the maximum uri issue and also just provide another option for using the API.