Dev pr1 : add model and vocoder abstraction #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one requires some decision on general 🐸 TTS design in accord with #9 |
|
Sure! I will write there what I wrote in the matrix 3 weeks ago about why I think abstraction can be good |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
eginhard
referenced
this pull request
in idiap/coqui-ai-TTS
Apr 2, 2024
fix(api): handle missing attribute in is_multi_lingual
gravityrail
pushed a commit
to gravityrail/TTS
that referenced
this pull request
Jul 8, 2024
feat(xtts): support Hindi for sentence-splitting and fine-tuning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
Here the first split of the PR i did earlier this week.
This first PR concerns the abstraction code that I wrote for the vocoder and tts model. This way, we can use type hinting in the other place in the repo to help us to write correct code :).