Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: Log ix names by default, is feature that can be turned off #1057

Merged
merged 5 commits into from
Nov 24, 2021
Merged

lang: Log ix names by default, is feature that can be turned off #1057

merged 5 commits into from
Nov 24, 2021

Conversation

paul-schaaf
Copy link
Contributor

closes #1038

@fanatid
Copy link
Contributor

fanatid commented Nov 24, 2021

It's more about naming than real request, but add this feature by default and rename to no-log-ix-name as no-idl?

Thanks for the pull request!

@paul-schaaf
Copy link
Contributor Author

@fanatid done

armaniferrante
armaniferrante approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@armaniferrante armaniferrante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog entry for this.

@armaniferrante armaniferrante merged commit 8a30d87 into coral-xyz:master Nov 24, 2021
This was referenced Nov 27, 2021
Merged
Closed
@paul-schaaf paul-schaaf deleted the lang__add_instruction_name_logging branch November 27, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanatid fanatid fanatid left review comments

@armaniferrante armaniferrante armaniferrante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lang: Log instruction names by default
3 participants
@paul-schaaf @fanatid @armaniferrante