-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for simple wilcard Anchor.toml's workspace.members #2785
Conversation
@GabrielePicco is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this should work but can we get rid of explicit panic!
s? I'm aware the previous code also had it but let's not add more of it since this method already returns a Result
so that the error can be handled gracefully.
It would also be great to have this for workspace.exclude
:
Lines 318 to 332 in ef3b149
let exclude = self | |
.workspace | |
.exclude | |
.iter() | |
.map(|m| { | |
self.path() | |
.parent() | |
.unwrap() | |
.join(m) | |
.canonicalize() | |
.unwrap_or_else(|_| { | |
panic!("Error reading workspace.exclude. File {:?} does not exist at path {:?}.", m, self.path) | |
}) | |
}) | |
.collect(); |
Co-authored-by: acheron <98934430+acheroncrypto@users.noreply.github.com>
@acheroncrypto I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Before we merge, could you note this change in the CHANGELOG?
Sure. Noted in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Add support for simple wilcard Anchor.toml's workspace.members
See #2784 and #2658 for context