Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time crate version issue by updating to version >=0.3.35 #3264

Closed
wants to merge 3 commits into from

Conversation

igdev0
Copy link

@igdev0 igdev0 commented Sep 21, 2024

This PR resolves an issue with the time crate that caused a build failure when using Rust version 1.80.0 or higher. The error was due to a breaking change in Rust that affected earlier versions of the time crate. The fix updates the time crate to version >=0.3.35, which is compatible with Rust 1.80.0+.

Issue:
Building the package with Rust 1.80.0+ resulted in the following error:
error: this is an inference error on crate time caused by an API change in Rust 1.80.0

Copy link

vercel bot commented Sep 21, 2024

@igdev0 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@igdev0 igdev0 marked this pull request as draft September 21, 2024 09:37
@igdev0 igdev0 closed this Sep 21, 2024
@igdev0 igdev0 reopened this Sep 21, 2024
@igdev0 igdev0 marked this pull request as ready for review September 21, 2024 09:41
@acheroncrypto acheroncrypto added invalid This doesn't seem right dependencies Pull requests that update a dependency file labels Sep 21, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR resolves an issue with the time crate that caused a build failure when using Rust version 1.80.0 or higher.

Thanks but this PR doesn't resolve the problem it claims it does, as the problem has already been fixed in #3143.

Also, if you check the changes in this PR, you'd see it doesn't even touch the time dependency, but it changes versions of a bunch of unrelated dependencies, probably as a result of blindly running cargo update.

@igdev0
Copy link
Author

igdev0 commented Sep 21, 2024

Honestly, didn't find the time dependency, but it worked after I ran cargo update, so I assumed the bunch of dependencies were depending on time crate lower than the one supported by rust >=v1.80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants