Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit usage of deprecated reflect.StringHeader #1147

Closed
M4tteoP opened this issue Sep 6, 2024 · 0 comments · Fixed by #1162
Closed

Revisit usage of deprecated reflect.StringHeader #1147

M4tteoP opened this issue Sep 6, 2024 · 0 comments · Fixed by #1162

Comments

@M4tteoP
Copy link
Member

M4tteoP commented Sep 6, 2024

reflect.StringHeader has been deprecated since Go 1.22. Context of our usage: #553

coraza/internal/corazawaf/rule.go

Line 402 in be8c6af

argKeyPtr := (*reflect.StringHeader)(unsafe.Pointer(&argKey)).Data // nolint:staticcheck

See also #1145 (comment) for a possible alternative (to be further explored and tested).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace reflect.StringHeader with unsafe.StringData Juneezee/coraza
1 participant
@M4tteoP