Use pointer for arg key in cache key #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inyGo to work well
anuraaga
changed the title
Codecov ReportBase: 78.50% // Head: 78.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #553 +/- ##
=======================================
Coverage 78.50% 78.51%
=======================================
Files 145 145
Lines 6955 6958 +3
=======================================
+ Hits 5460 5463 +3
Misses 1263 1263
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
anuraaga
changed the title
|
LGTM, anyways we can change it any moment as this is internal. |
|
Cool, then need approval to merge |
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does happen to work and enables TinyGo to work well
See tinygo-org/tinygo#3354 for context
I found that TinyGo does not handle map keys with embedded variable-length fields (basically just
stringI guess) well, converting to interface and using reflection, which causes allocations and general slowness.The arg key string coincidentally has a stable pointer for our purposes here...so we can use it.
This is an alternative to #552 but is very hacky. If it seems like too much, we can give up on the cache for now. But I do think the cache is important for performance so maybe we can live with it. I would be surprised if FTW were to pass in the future if a bug was caused by the pointer stability property not being valid anymore, so that safety measure is there, I guess.