Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADCIO-4763) fix: add icon prefix to icon svg file #114

Merged
merged 2 commits into from
Aug 9, 2024
Merged

ADCIO-4763) fix: add icon prefix to icon svg file #114

merged 2 commits into from
Aug 9, 2024

Conversation

dev-redo
Copy link
Contributor

@dev-redo dev-redo commented Aug 9, 2024 •
edited
Loading

πŸ”— Jira Ticket Number

♻️ Current situation

πŸ’‘ Proposed solution

image

  • icon 폴더에 μ΄μŠˆκ°€ λ°œμƒλ˜μ–΄ λΉŒλ“œκ°€ λ˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
  • ν˜„μž¬ icon μ»΄ν¬λ„ŒνŠΈ 넀이밍이 Icon-이 λΆ™μ–΄μžˆλŠ”λ°, exportν•  λ•ŒλŠ” Icon-이 뢙지 μ•Šμ•„μ„œ λ°œμƒλ˜λŠ” μ΄μŠˆμž…λ‹ˆλ‹€.

βž• Additional Information

image

  • icon svg에 icon prefixλ₯Ό 뢙이고 λ‹€μ‹œ icongen ν–ˆμŠ΅λ‹ˆλ‹€.
  • μœ„μ™€ 같이 μˆ˜μ •ν–ˆλ”λ‹ˆ, 각 μ•„μ΄μ½˜ μ»΄ν¬λ„ŒνŠΈ 이름과 νŒŒμΌμ— Icon- prefixκ°€ λΆ™κ³ , λΉŒλ“œκ°€ 잘 λ©λ‹ˆλ‹€.

πŸ§ͺ Testing

πŸ§‘β€πŸ’» Reviewer Nudging

βœ… Checklist

  • μˆ˜μ • 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό λ§ˆμ³€μŠ΅λ‹ˆλ‹€.
  • κ΄€λ ¨ λ…Έμ…˜ λ¬Έμ„œλ₯Ό μ—…λ°μ΄νŠΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • λ””μžμΈ μ‹œμŠ€ν…œ μ»΄ν¬λ„ŒνŠΈμ˜ 경우 rmp PR 번호 첨뢀 및 CDS 라벨을 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

@dev-redo dev-redo added the fix fix past feature that does not have bug label Aug 9, 2024
@dev-redo dev-redo self-assigned this Aug 9, 2024
@dev-redo dev-redo requested review from lebmouse and dohui-son August 9, 2024 04:54
lebmouse
lebmouse approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@lebmouse lebmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@dev-redo dev-redo merged commit ce03e4c into main Aug 9, 2024
@dev-redo dev-redo deleted the fix/fix-adcio-4763 branch August 9, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebmouse lebmouse lebmouse approved these changes

@dohui-son dohui-son Awaiting requested review from dohui-son

Assignees

@dev-redo dev-redo

Labels
fix fix past feature that does not have bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-redo @lebmouse