Skip to content

Commit

Permalink
tests: modem: cmux: add missing timeout param
Browse files Browse the repository at this point in the history
Add the missing timeout parameter to `modem_pipe_open()` and
`modem_pipe_close()` calls.
10 seconds is the default value used in the Zephyr tree.

Fixes a regression introduced in
zephyrproject-rtos/zephyr#74325.

(cherry picked from commit 48d69b4)

Original-Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
GitOrigin-RevId: 48d69b4
Change-Id: I3c3938e8f1baa75e13b838b0a5a9b7c18f69ac29
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5748700
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
  • Loading branch information
tomi-font authored and Chromeos LUCI committed Jul 30, 2024
1 parent ab458f7 commit 26d778c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tests/subsys/modem/modem_cmux/src/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -793,14 +793,14 @@ ZTEST(modem_cmux, test_modem_cmux_prevent_work_while_released)
/* Validate no new requests can be submitted */
modem_cmux_connect(&cmux);
modem_cmux_disconnect(&cmux);
modem_pipe_open(dlci1_pipe);
modem_pipe_open(dlci2_pipe);
modem_pipe_open(dlci1_pipe, K_SECONDS(10));
modem_pipe_open(dlci2_pipe, K_SECONDS(10));
modem_pipe_transmit(dlci1_pipe, transmit, sizeof(transmit));
modem_pipe_transmit(dlci2_pipe, transmit, sizeof(transmit));
modem_pipe_receive(dlci1_pipe, receive, sizeof(receive));
modem_pipe_receive(dlci2_pipe, receive, sizeof(receive));
modem_pipe_close(dlci1_pipe);
modem_pipe_close(dlci2_pipe);
modem_pipe_close(dlci1_pipe, K_SECONDS(10));
modem_pipe_close(dlci2_pipe, K_SECONDS(10));
k_msleep(500);
zassert_true(modem_backend_mock_get(&bus_mock, buffer1, sizeof(buffer1)) == 0);

Expand All @@ -809,9 +809,9 @@ ZTEST(modem_cmux, test_modem_cmux_prevent_work_while_released)
modem_backend_mock_prime(&bus_mock, &transaction_control_sabm);
zassert_ok(modem_cmux_connect(&cmux));
modem_backend_mock_prime(&bus_mock, &transaction_dlci1_sabm);
zassert_ok(modem_pipe_open(dlci1_pipe));
zassert_ok(modem_pipe_open(dlci1_pipe, K_SECONDS(10)));
modem_backend_mock_prime(&bus_mock, &transaction_dlci2_sabm);
zassert_ok(modem_pipe_open(dlci2_pipe));
zassert_ok(modem_pipe_open(dlci2_pipe, K_SECONDS(10)));
}

ZTEST_SUITE(modem_cmux, NULL, test_modem_cmux_setup, test_modem_cmux_before, NULL, NULL);

0 comments on commit 26d778c

Please sign in to comment.