Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: run clippy on tests #1201

Merged
merged 2 commits into from
Jun 2, 2023
Merged

workflows: run clippy on tests #1201

merged 2 commits into from
Jun 2, 2023

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jun 1, 2023

By default, cargo clippy does not check tests. Run it with --all-targets to fix this. For consistency, add the same option to cargo build and cargo test.

By default, `cargo clippy` does not check tests.  Run it with
--all-targets to fix this.  For consistency, add the same option to
`cargo build` and `cargo test`.
@bgilbert bgilbert added the skip-notes This PR does not need release notes label Jun 1, 2023
@bgilbert bgilbert requested a review from prestist June 1, 2023 22:22
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert enabled auto-merge June 2, 2023 03:38
@bgilbert bgilbert merged commit 082f9cb into coreos:main Jun 2, 2023
@bgilbert bgilbert deleted the clippy branch June 2, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-notes This PR does not need release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants