rdcore: Juggle physical root versus deployment root #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this one? |
|
Ping |
|
I'd really like to turn on composefs by default soon for ostree, and this is going to block that. |
The FCOS coreos-boot-edit.sh runs both of these, and it wasn't immediately clear to me which of them was failing.
cgwalters
force-pushed
the
composefs-rootmap
branch
from
3dc9e32
to
bc209f5
Compare
This is prep for supporting composefs, where the physical root is distinct from the deployment root. Specifically for the LUKS case, we can find `/etc/crypttab` only in the deployment root. Otherwise, we suffix the passed path (usually `/sysroot`) that was mounted in the initramfs with `/sysroot` to find the physical root. xref ostreedev/ostree#2867
jlebon
force-pushed
the
composefs-rootmap
branch
from
bc209f5
to
22d4f2b
Compare
jlebon
approved these changes
Nov 6, 2023
|
Looks like there hasn't been a release since this got merged? This is blocking composefs enablement in rawhide which I'd like to do soon. |
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Dec 5, 2023
The goal is to start shaking out integration issues. This currently blocks on a release of coreos-installer with coreos/coreos-installer#1203
|
We should be cutting a release soon. I opened #1349. |
This was referenced Dec 6, 2023
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Jan 2, 2024
Prep for enabling composefs. This is the same issue as coreos/coreos-installer#1203
cgwalters
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Jan 3, 2024
Prep for enabling composefs. This is the same issue as coreos/coreos-installer#1203
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Jan 3, 2024
The goal is to start shaking out integration issues. This currently blocks on a release of coreos-installer with coreos/coreos-installer#1203
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Jan 3, 2024
Yet another instance of the same problem as coreos/coreos-installer#1203 Motivated by enabling composefs compatibility.
cgwalters
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Jan 3, 2024
Yet another instance of the same problem as coreos/coreos-installer#1203 Motivated by enabling composefs compatibility.
aaradhak
pushed a commit
to aaradhak/fedora-coreos-config
that referenced
this pull request
Mar 18, 2024
Prep for enabling composefs. This is the same issue as coreos/coreos-installer#1203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdcore: Juggle physical root versus deployment root
This is prep for supporting composefs, where the physical root
is distinct from the deployment root. Specifically for the LUKS
case, we can find
/etc/crypttabonly in the deployment root.Otherwise, we suffix the passed path (usually
/sysroot) thatwas mounted in the initramfs with
/sysrootto find the physicalroot.
xref ostreedev/ostree#2867