Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: improve request took too long warning #9288

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Feb 6, 2018

fix #9111

range and txn readonly range need special care in its own funcs since these two kinds of request wont go through raft to be applied.

example output

2018-02-06 12:14:01.589768 W | etcdserver: read-only range request "key:\"\\000\" range_end:\"\\000\" " took too long [3.389041388s] to execute

to trigger the warning, try to put 1M keys into etcd and do a large range over the entire 1M keys.

/cc @hexfusion please take a look. thanks!

@xiang90
Copy link
Contributor Author

xiang90 commented Feb 6, 2018

@gyuho probably we can backport this small improvement to 3.3 as well. it is helpful for debugging purpose.

@gyuho
Copy link
Contributor

gyuho commented Feb 6, 2018

@xiang90 Ack. And lgtm. Thanks.

@xiang90
Copy link
Contributor Author

xiang90 commented Feb 6, 2018

@jpbetz not sure if k8s cluster can hit this warning frequently. if it is, i suggest to backport this to 3.1 as well to help users to debug.

@xiang90
Copy link
Contributor Author

xiang90 commented Feb 6, 2018

/cc @WIZARD-CXY

@hexfusion
Copy link
Contributor

@xiang90 lgtm will populate test ENV this evening, thanks.

@xiang90 xiang90 merged commit 11214aa into etcd-io:master Feb 6, 2018
@WIZARD-CXY
Copy link
Contributor

ack.

@xiang90 xiang90 deleted the wl branch February 7, 2018 00:51
jpbetz added a commit to jpbetz/etcd that referenced this pull request Jun 7, 2018
gyuho referenced this pull request Jun 12, 2018
…rigin-release-3.2

Automated cherry pick of detailed "took too long" warnings to release-3.2
jpbetz added a commit to jpbetz/etcd that referenced this pull request Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

print out the request detail when it takes too long to process
4 participants