-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of detailed "took too long" warnings to release-3.2 #9821
Automated cherry pick of detailed "took too long" warnings to release-3.2 #9821
Conversation
After discussing with @gyuho, we'd like to only log the payload size, and not the payload contents, so we'll first fix that on master and then cherrypick it back. This PR will be on hold until we sort that out. |
@gyuho Ah, I need that as well. I'll augment |
5c6f444
to
18a8737
Compare
18a8737
to
0ce2ef1
Compare
I'll send out a 3.3 backport shortly. |
@jpbetz Oh, those are already backported to 3.3 yesterday :) LGTM. thanks! |
…rigin-release-3.1-1528833932 etcdserver: Automated cherry pick of detailed "took too long" warnings to release-3.1
Cherry pick request "took too long" warning improvements to release-3.2.
To improve debuggability of etcd. This is important since etcd 3.1+ no longer appended quorum writes to WAL log, and this will the only record expensive requests.
#9288: etcdserver: improve request took too long warning
#9661: etcdserver: not print password in the warning message of expensive request
#9822: etcdserver: Replace value contents with value_size in request took too long warning
#9826: etcdserver: Add response byte size and range response count to took too long warning
#9835: etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer