This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
shortsubject: skip when commit is a merge commit #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| vr.Pass = false | ||
| vr.Msg = "commit subject exceeds 90 characters" | ||
| return | ||
| } | ||
|
|
||
| vr.Pass = true | ||
| if len(c["subject"]) > 72 { | ||
| vr.Msg = "commit subject is under 90 characters, but is still more than 72 chars" |
There was a problem hiding this comment.
this is no longer necessary true. could do with another conditional branch dealing with the new case
tmrts
force-pushed
the
fix/shortsubject-merge-commits
branch
from
5d327c0
to
e589c9a
Compare
| @@ -21,11 +23,18 @@ func init() { | |||
| // ValidateShortSubject checks that the commit's subject is strictly less than | |||
| // 90 characters (preferably not more than 72 chars). | |||
| func ValidateShortSubject(c git.CommitEntry) (vr validate.Result) { | |||
| if len(strings.Split(c["parent"], " ")) <= 1 { | |||
tmrts
force-pushed
the
fix/shortsubject-merge-commits
branch
from
e589c9a
to
754440d
Compare
This was referenced May 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://travis-ci.org/coreos/rkt/jobs/132579478
cc @lucab