Fix: iptables stats tests for iptables >= 1.8.9 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
approved these changes
Oct 23, 2023
IPTables fixed a couple long-standing discrepancies in ipv4/ipv6's -L output. Unfortunately these fixes break out tests and potentially, stat parsing. In detail, the following were fixed in 1.8.9 and later: * ip6tables' opt column outputting spaces instead of dashes * ip6tables' prot column not resolving "all" to "0", even with numeric mode activated. * iptables' prot column not resolving "all" to "0", even with numeric mode activated. Handle them, so that tests keep working post 1.8.9.
costasd
force-pushed
the
fix_iptables_tests_189
branch
from
1b5df17
to
73a26db
Compare
Ouch, sorry about that, missed the conditional for IPv4. Added, should work now. Thanks! |
squeed
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPTables fixed a couple long-standing discrepancies in ipv4/ipv6's -L output.
Unfortunately these fixes break out tests and potentially, stat parsing.
In detail, the following were fixed in 1.8.9 and later:
Handle them, so that tests keep working post 1.8.9.