-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go-jose to fix CVE-2024-28180 #417
Comments
This bumps the go-jose dependency to a version that addresses vulnerability CVE-2024-28180. Closes coreos#417
I just realised that the API also changes, which likely means a go-oidc v4 as well. The big difference is that
Trying to figure out what should we do here as it really doesn't make sense from an API perspective to request this when the string JWT has that encoded. |
go-oidc intentional doesn't export anything that references its I can take a crack at updating. If I'm reading the new signature right this might actually fix #356 as well Regardless, the CVE is for JWE implementation issues which this package doesn't use. v3.0.3 also appears to have the fix. |
Fair point. I didn't validate whether it was being used or not, and I was also being misled by the v4.0.1 release notes. #418 does the bump, but I tried to take a stab at using 4.0.1 (the one where the API changes). In interest of enabling #356 I can try contributing. |
Two weeks ago github.com/go-jose/go-jose released v.4.0.1 to fix a published vulnerability (CVE-2024-28180.
This is issue is to bump the dependency from v3.0.1 to v4.0.1.
(I can do a pull request with the bump)
The text was updated successfully, but these errors were encountered: