-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add a go.mod file #228
*: add a go.mod file #228
Conversation
Should we bump these? Lines 4 to 5 in 2be1c5b
|
https://golang.org/doc/devel/release.html#policy 1.13, 1.12? |
Bumped in #227 :) |
I'll pull it out into this PR |
Should not this be /v2 or better /v3 module? |
Happy to do that for later breaking changes, but I'd rather not force users to change the import path today. |
Generated using the following commands: go mod init github.com/coreos/go-oidc go mod tidy
Would you not need to change it anyway from |
This package doesn't use gopkg.in. Though it does look like some people import it this way... https://godoc.org/gopkg.in/coreos/go-oidc.v2?importers I'll open bugs against those importers. |
And my private project too :-), hence the confusion. |
This is documented in the godoc link, examples, and now the go.mod. I think that should be good :) |
Generated using the following commands:
Fixes #218
NOTE: this is expected to fail due to travis issues until #227 is merged and this is rebased.