*: remove Cache-Control checks from key rotation strategy #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the dependency on github.com/pquerna/cachecontrol and brings the package more inline with the strategy from the OpenID Spec for rotation. https://openid.net/specs/openid-connect-core-1_0.html#RotateSigKeys
|
The reason this was held back is because it does change behavior for existing APIs. What is preventing you from upgrading to v3? |
Agreed, but the current behaviour in v2 essentially means we have to restart whenever our OIDC provider rotates their keys.
This is probably preferable but v3 is untagged right now. Can a release be tagged then? |
|
I sent a PR to update the README (#285), but I think we're basically good to tag v3 otherwise. |
|
Amazing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #259 (minus
go.{mod,sum}changes) onto v2.We need this as the bug fix is only in the non-tagged v3 branch.
Closes #272.