*: remove dependency on capnslog #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capnslog hijacks the standard loggers as an import side effect. For some reason in dex this is causing the standard logger to not log anything. For example net/http just swallows panics in handlers without printing stack traces. I'm having trouble tracking this down in dex, but removing the capnslog's logging hijacker init() fixed this, so we're just going to remove the dependency altogether. Importing go-oidc shouldn't alter the standard logger anyway.
| func (l *LoggingMiddleware) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
| log.Infof("HTTP %s %v", r.Method, r.URL) | ||
| l.Next.ServeHTTP(w, r) | ||
| } |
There was a problem hiding this comment.
This is more than just a log implementation change. Why remove the middleware?
I'm ok with this if it wasn't being used (likely).
There was a problem hiding this comment.
- We're not using it in dex.
- This implementation is tied to the capnslog package so it seemed reasonable to remove as part of this diff. It's basically a "log to capnslog middleware"
|
otherwise LGTM |
|
cool, merging |
ericchiang
added a commit
to ericchiang/kubernetes
that referenced
this pull request
Aug 26, 2016
This change updates the github.com/coreos/go-oidc package. Notable changes: - Throw out JWTs with invalid claims early (coreos/go-oidc#97, brougt up in kubernetes#30457) - Remove the capnslog dependency (coreos/go-oidc#95) - Support for Azure AD oddities (coreos/go-oidc#87)
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 12, 2016
Automatic merge from submit-queue vendor: update github.com/coreos/go-oidc client package This change updates the github.com/coreos/go-oidc package to it's latest commit (since we don't version that package). Notable changes: - Throw out JWTs with invalid claims early (coreos/go-oidc#97, brougt up in #30457) - Remove the capnslog dependency (coreos/go-oidc#95) - Support for Azure AD oddities (coreos/go-oidc#87) cc @kubernetes/sig-auth
lukaszraczylo
pushed a commit
to lukaszraczylo/go-oidc
that referenced
this pull request
Apr 13, 2024
capnslog hijacks the standard loggers as an import side effect. For some reason in dex this is causing the standard logger to not log anything. For example net/http just swallows panics in handlers without printing stack traces. I'm having trouble tracking this down in dex, but removing the capnslog's logging hijacker init() fixed this, so we're just going to remove the dependency altogether. Importing go-oidc shouldn't alter the standard logger anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capnslog hijacks the standard loggers as an import side effect. For
some reason in dex this is causing the standard logger to not log
anything. For example net/http just swallows panics in handlers
without printing stack traces.
I'm having trouble tracking this down in dex, but removing the
capnslog's logging hijacker init() fixed this, so we're just going
to remove the dependency altogether. Importing go-oidc shouldn't
alter the standard logger anyway.