-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit: use ContainsAny instead of IndexAny #263
Conversation
I have a minimum Go version bump (to >=1.10) on my roadmap, but I'm waiting for at least Go 1.11 to be released before doing that. I think I'm going to merge this PR at that later point. Bumping will also require some Travis adjustment. For the moment, I'll keep this open and wait. In general it looks good, thanks a lot! |
@lucab Will do! |
2e2dbf4
to
8b7ed52
Compare
Pushed. This would bump the minimum required Go version to 1.7. I'm not sure it's worth bumping the requirement for this change alone, though, to be honest. That being said, 1.7 also came with Happy to keep this alive until we eventually decide to bump the requirement. |
Ack, I'll keep this around open. We can queue it anytime in the future when we will need to bump the toolchain. |
@muesli mind rebasing on current master? Minimum toolchain just bumped to 1.7 due to go-dbus anyway. |
Will do in a minute! |
61c1c7b
to
cdcfe50
Compare
@lucab Good to go from my POV. |
The one failed Travis job looks like a fluke / unlikely name clash to me? Edit: I'll force push to my branch to test that theory... |
cdcfe50
to
7827196
Compare
Yes, it's a known flake: #290 I re-triggered and it's green now, merging. Thanks a lot (with some delay 😄)! |
Caution: If I'm not mistaken
ContainsAny
wasn't available before Go 1.5. I'm not sure which minimum Go version go-systemd is aiming for, but if it's still <1.5 then you might not want to merge this PR.That being said, I think it reads nicer.
Edit: I was mistaken,
bytes.ContainsAny
was introduced with the 1.7 release.