sdjournal: drop conditional static specifier #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_SD_ARRAY_STATIC` is a custom / conditional macro for static C99 array size, which got introduced in recent libsystemd and thus cannot build on older versions. Due to how it is currently used in our Go wrapper, it can be safely omitted from here. Ref: systemd/systemd@4199f68
lucab
force-pushed
the
ups/sdjournal-conditional-static
branch
from
c6ca3f3 to
cb9eb60
Compare
giuseppe
approved these changes
Mar 17, 2021
|
@giuseppe this fix is now into https://github.com/coreos/go-systemd/releases/tag/v22.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SD_ARRAY_STATICis a custom / conditional macro for static C99array size, which got introduced in recent libsystemd and thus cannot
build on older versions.
Due to how it is currently used in our Go wrapper, it can be safely
omitted from here.
Ref: systemd/systemd@4199f68
Fixes: #355