KVM: Hypervisor support for KVM flavor #2684

jjlakis · 2016-05-24T15:40:57Z

Here's the first PR in our plan to put some focus on qemu as a KVM hypervisor. Whole code is based on Michał Stachowski's (@mstachowski) work in #2592 ,and it's taken by me, due to the other activities inside our company that Michał must handle. We're also closing #2592.
This code provides a generic mechanism to use different kvm hypervisors (such as lkvm, qemu-kvm), to set it by passing proper option to ./configure (New configure option --with-stage1-kvm-hypervisor). This PR covers only implementation of KvmHypervisor type and a small refactor of kvm's part of init.go to match the new KvmHypervisor interface (lkvm is the only option that could be passed to --with-stage1-kvm-hypervisor and it's also default)
I fixed most of the review suggestions from #2592

jjlakis · 2016-05-24T15:58:57Z

The reason of failing Travis-CI check is:

21197c3 "Merge pull request Add way to access logs from stopped container to docs #2620 from matthaias/add-way-to-access-logs-from-stopped-container-to-docs" ... FAIL commit subject exceeds 90 characters

CC @alban

lucab · 2016-05-24T16:31:34Z

Validator glitch, coreos/git-validation#5 should fix it. I just restarted this job on travis.

@lucab

Complains when the commit is a merge commit, it shouldn't! Discovered in #2684 cc @lucab

tmrts · 2016-05-24T16:49:16Z

I kickstarted the Travis build, should be good now

jellonek · 2016-05-24T18:12:23Z

Travis is still failing.

tmrts · 2016-05-24T18:37:44Z

@jellonek It's related to git validation, but Semaphore is green, so it should be safe to merge after a review

@lucab

Complains when the commit is a merge commit, it shouldn't! Discovered in rkt#2684 cc @lucab

hectorj2f · 2016-05-28T19:54:11Z

@jjlakis I'd like to test this PR, I started playing with #2592. But I cannot access to this branch.

jellonek · 2016-05-28T22:25:17Z

What stops you? Did you added https://github.com/intelsdi-x/rkt.git as separate git remote?

hectorj2f · 2016-05-28T23:12:50Z

@jellonek I was expecting to directly use this branch intelsdi-x:jlakis-hypervisor :). But I'd now use the rkt fork of intelsdi.

jellonek · 2016-05-29T09:15:11Z

Mentioned branch is based on master from this coreos/rkt repository. There is no difference in both forks other than it's easier to start working on rkt by new guy at Intel, before one would get privilege to push into coreos/rkt.
So there is no reason to be sad about this - this is usual situation in collaboration on github ;)

s-urbaniak · 2016-06-03T10:57:17Z

stage1/init/kvm/hypervisor/lkvm_driver.go

+)
+
+func StartCmd(wdPath, name, kernelPath string, nds []kvm.NetDescriber, cpu, mem int64, debug bool) ([]string, error) {
+


superfluous newline

jjlakis · 2016-07-18T13:55:09Z

All tests passing

iaguis · 2016-07-18T14:09:26Z

configure.ac

+            [AS_HELP_STRING([--with-stage1-kvm-hypervisor],
+                            [hypervisor used by 'kvm' flavor; default and only option for now: 'lkvm'])],
+	    [RKT_STAGE1_KVM_HV="${withval}"],
+	    [RKT_STAGE1_KVM_HV='lkvm'])


there're tabs on these lines, please use only spaces

iaguis · 2016-07-18T14:11:46Z

LGTM after the nits

iaguis · 2016-07-18T14:47:40Z

stage1/init/kvm/hypervisor/hypervisor.go

+	KernelParams []string
+}
+
+// InitKernelParams sets debug and common parameters passed to kernel and debug parameters


Last thing: please remove the trailing " and debug parameters" and s/to kernel/to the kernel/.

iaguis · 2016-07-18T15:07:01Z

Tests passed before and the changes afterwards were just cosmetic. Merging.

squall0gd · 2016-07-20T11:10:17Z

It's good to see this in master :)

jonboulle · 2016-07-25T21:56:05Z

\o/

On 20 July 2016 at 13:10, Michał Stachowski notifications@github.com
wrote:

It's good to see this in master :)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2684 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN988kH8v22DaMNBUqY1iiaHyr_KCks5qXgIigaJpZM4IloPM
.

jjlakis force-pushed the jlakis-hypervisor branch from ae4a187 to 8064dda Compare May 24, 2016 15:53

jjlakis changed the title ~~Hypervisor support for KVM flavor~~ KVM: Hypervisor support for KVM flavor May 24, 2016

tmrts added a commit that referenced this pull request May 24, 2016

git-validation: disable short-subject validation

93c5371

Complains when the commit is a merge commit, it shouldn't! Discovered in #2684 cc @lucab

tmrts mentioned this pull request May 24, 2016

git-validation: disable short-subject validation #2685

Merged

lucab added kind/enhancement technology/kvm needs/review labels May 24, 2016

tmrts added a commit to tmrts/rkt that referenced this pull request May 25, 2016

git-validation: disable short-subject validation

61bd75b

Complains when the commit is a merge commit, it shouldn't! Discovered in rkt#2684 cc @lucab

jjlakis force-pushed the jlakis-hypervisor branch from 8064dda to ff3e56b Compare May 25, 2016 12:36

jonboulle added this to the v1.9.0 milestone May 27, 2016

jjlakis force-pushed the jlakis-hypervisor branch 2 times, most recently from 93798b0 to 4c52578 Compare May 30, 2016 08:55

jonboulle added the help wanted label May 31, 2016

s-urbaniak reviewed Jun 3, 2016
View reviewed changes

jjlakis force-pushed the jlakis-hypervisor branch 3 times, most recently from 8508957 to 40fc66f Compare July 18, 2016 13:00

iaguis reviewed Jul 18, 2016
View reviewed changes

alban added reviewed/lgtm and removed kind/enhancement needs/some-changes labels Jul 18, 2016

alban added needs/some-changes and removed reviewed/lgtm labels Jul 18, 2016

make: Add configure option to set KVM hypervisor.

aede5d8

jjlakis force-pushed the jlakis-hypervisor branch from 40fc66f to 0919e07 Compare July 18, 2016 14:28

iaguis added the reviewed/lgtm label Jul 18, 2016

iaguis reviewed Jul 18, 2016
View reviewed changes

alban mentioned this pull request Jul 18, 2016

stage1/init: link pod's journal in kvm flavor #2934

Merged

jjlakis force-pushed the jlakis-hypervisor branch from 0919e07 to a29797f Compare July 18, 2016 14:56

Jacek J. Łakis added 3 commits July 18, 2016 16:56

KVM: Add hypervisor prototype

08eea2f

KVM: Refactor current lkvm code to start as a hypervisor driver

622f929

KVM: Add none driver to prevent non-kvm flavors build problems

a29797f

iaguis merged commit 1336ab9 into rkt:master Jul 18, 2016

jjlakis mentioned this pull request Jul 19, 2016

[DO NOT MERGE]Hypervisor QEMU PR intelsdi-x/rkt#43

Closed

jjlakis mentioned this pull request Jul 20, 2016

Introduce QEMU support #2952

Merged

mzylowski deleted the jlakis-hypervisor branch August 1, 2016 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KVM: Hypervisor support for KVM flavor #2684

KVM: Hypervisor support for KVM flavor #2684

jjlakis commented May 24, 2016 •

edited

Loading

jjlakis commented May 24, 2016 •

edited

Loading

lucab commented May 24, 2016

tmrts commented May 24, 2016

jellonek commented May 24, 2016

tmrts commented May 24, 2016

hectorj2f commented May 28, 2016

jellonek commented May 28, 2016

hectorj2f commented May 28, 2016

jellonek commented May 29, 2016

s-urbaniak Jun 3, 2016

jjlakis commented Jul 18, 2016

iaguis Jul 18, 2016

iaguis commented Jul 18, 2016 •

edited

Loading

iaguis Jul 18, 2016

iaguis commented Jul 18, 2016

squall0gd commented Jul 20, 2016

jonboulle commented Jul 25, 2016

		)

		func StartCmd(wdPath, name, kernelPath string, nds []kvm.NetDescriber, cpu, mem int64, debug bool) ([]string, error) {

KVM: Hypervisor support for KVM flavor #2684

KVM: Hypervisor support for KVM flavor #2684

Conversation

jjlakis commented May 24, 2016 • edited Loading

jjlakis commented May 24, 2016 • edited Loading

lucab commented May 24, 2016

tmrts commented May 24, 2016

jellonek commented May 24, 2016

tmrts commented May 24, 2016

hectorj2f commented May 28, 2016

jellonek commented May 28, 2016

hectorj2f commented May 28, 2016

jellonek commented May 29, 2016

s-urbaniak Jun 3, 2016

Choose a reason for hiding this comment

jjlakis commented Jul 18, 2016

iaguis Jul 18, 2016

Choose a reason for hiding this comment

iaguis commented Jul 18, 2016 • edited Loading

iaguis Jul 18, 2016

Choose a reason for hiding this comment

iaguis commented Jul 18, 2016

squall0gd commented Jul 20, 2016

jonboulle commented Jul 25, 2016

jjlakis commented May 24, 2016 •

edited

Loading

jjlakis commented May 24, 2016 •

edited

Loading

iaguis commented Jul 18, 2016 •

edited

Loading