Add ex deploy-from-self
#3961
Merged
Add ex deploy-from-self
#3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
ex-inplace-container-deploy
branch
2 times, most recently
from
6bb7086
to
e6b6cf8
Compare
This experimental command is intended to be mainly used in OCP where we're trying to do a cutover to the new format container images. However, we have the problem of old disk images where the rpm-ostree there is too old to understand the container bits. (Not to mention skopeo is too old) This code (+ integration test) demonstrates running the new OS update *as a privileged container* which mounts the host filesystem and performs the update that way. A downside of this is that we only write the raw ostree commit; we don't write the container-ostree refs; in other words, the next update will need to re-pull the container. That's...fixable, it just requires a bit more nontrivial work that we can do later as an optimization.
cgwalters
force-pushed
the
ex-inplace-container-deploy
branch
from
e6b6cf8
to
6f3370e
Compare
jmarrero
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experimental command is intended to be mainly used in OCP
where we're trying to do a cutover to the new format container images.
However, we have the problem of old disk images where the rpm-ostree
there is too old to understand the container bits. (Not to mention
skopeo is too old)
This code (+ integration test) demonstrates running the new OS
update as a privileged container which mounts the host filesystem
and performs the update that way.
A downside of this is that we only write the raw ostree commit;
we don't write the container-ostree refs; in other words, the
next update will need to re-pull the container. That's...fixable,
it just requires a bit more nontrivial work that we can do later
as an optimization.