Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ostree-ext 0.8.9 #4108

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Oct 27, 2022

tests: Add a test case that verifies remote registry + podman

This test case verifies rebasing and then upgrading from
a remote registry.


Update to ostree-ext 0.8.9

In particular this should fix us trying to load the authfile
Closes: #4107


@cgwalters cgwalters force-pushed the test-registry-container-update-reboot branch 2 times, most recently from f4133a5 to 8e1a255 Compare October 28, 2022 01:22
jmarrero
jmarrero previously approved these changes Oct 28, 2022
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jmarrero
jmarrero previously approved these changes Oct 28, 2022
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters
Copy link
Member Author

/retest

@cgwalters
Copy link
Member Author

Ah heh, I messed up the test in a different way. Let's try that again, verify it fails in the expected way, then I'll repush the ostree change.

This test case verifies rebasing and then upgrading from
a remote registry.
In particular this should fix us trying to load the authfile
Closes: coreos#4107
@cgwalters cgwalters force-pushed the test-registry-container-update-reboot branch from c5ef7e7 to 376d88b Compare October 28, 2022 18:51
@cgwalters
Copy link
Member Author

OK! I finally actually tested the new test case, with and without the fix.

@cgwalters cgwalters changed the title tests: Add a test case that verifies upgrading after rebasing Update to ostree-ext 0.8.9 Oct 28, 2022
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit 03f6e00 into coreos:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpm-ostree upgrade fails with ostree native containers
2 participants