Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation #616

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fix compilation #616

merged 2 commits into from
Sep 10, 2021

Conversation

taaem
Copy link
Contributor

@taaem taaem commented Feb 12, 2021

This change allows compilation on 64bit systems, by updating the build tools to their latest version (#386) and fixes the compilation script when building in a directory that has a space in its PATH (#588).

@hqwx2018
Copy link

hqwx2018 commented Apr 27, 2021

@taaem when I run build.bat, it cause error.
Error on line 16 in D:\Code\Github\nvm-windows\nvm.iss: Value of [Setup] section directive "SignTool" is invalid.
Compile aborted.
current branch is fix-compilation

@taaem
Copy link
Contributor Author

taaem commented Apr 27, 2021

@hqwx2018 The standard build script tries to sign the release, since for your local machine that should be unnecessary, you can disable that by changing these 2 lines in nvm.iss:

SignTool=MsSign $f
SignedUninstaller=yes

to

; SignTool=MsSign $f
; SignedUninstaller=yes

@hqwx2018
Copy link

@taaem thanks, it works.

Copy link
Owner

@coreybutler coreybutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, this looks good. I need to test it before merging.

@@ -55,14 +56,23 @@ WindowsServicePackRequired=This program requires %1 Service Pack %2 or later.
NotOnThisPlatform=This program will not run on %1.
OnlyOnThisPlatform=This program must be run on %1.
OnlyOnTheseArchitectures=This program can only be installed on versions of Windows designed for the following processor architectures:%n%n%1
MissingWOW64APIs=The version of Windows you are running does not include functionality required by Setup to perform a 64-bit installation. To correct this problem, please install Service Pack %1.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this section was removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied these files over from a new installation of the Inno Setup Compiler, any changes in those files happened, because they were in those new files.
I think one can easily roll those changes back if you want.

@coreybutler coreybutler merged commit 94bf865 into coreybutler:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants