-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation #616
Fix compilation #616
Conversation
@taaem when I run build.bat, it cause error. |
@hqwx2018 The standard build script tries to sign the release, since for your local machine that should be unnecessary, you can disable that by changing these 2 lines in
to
|
@taaem thanks, it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, this looks good. I need to test it before merging.
@@ -55,14 +56,23 @@ WindowsServicePackRequired=This program requires %1 Service Pack %2 or later. | |||
NotOnThisPlatform=This program will not run on %1. | |||
OnlyOnThisPlatform=This program must be run on %1. | |||
OnlyOnTheseArchitectures=This program can only be installed on versions of Windows designed for the following processor architectures:%n%n%1 | |||
MissingWOW64APIs=The version of Windows you are running does not include functionality required by Setup to perform a 64-bit installation. To correct this problem, please install Service Pack %1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this section was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied these files over from a new installation of the Inno Setup Compiler, any changes in those files happened, because they were in those new files.
I think one can easily roll those changes back if you want.
This change allows compilation on 64bit systems, by updating the build tools to their latest version (#386) and fixes the compilation script when building in a directory that has a space in its PATH (#588).