Implementations for u8->u64 and i8->i64 #873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first Rust-related PR, so apologies for any inadvertent mistakes.
I picked up dfdx yesterday but in my application I'm dealing with u8's and u16's a lot, and I figured it would be quite handy if we could properly interface them with Numpy instead of having to cast to f32/64 for the data exchange.
This PR adds support for the following dtypes:
u8
u16
u32
u64
i8
i16
i32
i64
I wasn't sure what the policy of this project is in regards to testing, so I added two basic save/load tests for
u8
andi8
to prove the concept. Let me know if I need to add all of the other tests as well. That'd be quite a few permutations in this case, so I didn't think it worth it for the initial PR.