Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kl628/card height #460

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Kl628/card height #460

merged 4 commits into from
Sep 30, 2023

Conversation

kevin-lin12
Copy link
Contributor

Summary

This pull request changes the line height.

  • Changed line height from 1.1 to 1.5

Test Plan

Screenshot 2023-09-26 at 6 56 19 PM

Notes

Breaking Changes

@kevin-lin12 kevin-lin12 requested a review from a team as a code owner September 26, 2023 22:56
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 4.

pratyush1712
pratyush1712 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@pratyush1712 pratyush1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a small suggestion: pls include the link to the Trello card in the PR description so it's easy to know what is being addressed in this PR.
(also congrats on the first PR? or is it the second? idk... but congrats on the first approved pr!)

@Atikpui007 Atikpui007 merged commit 9528c20 into master Sep 30, 2023
5 checks passed
@Atikpui007 Atikpui007 deleted the kl628/card-height branch September 30, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratyush1712 pratyush1712 pratyush1712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevin-lin12 @dti-github-bot @pratyush1712 @Atikpui007