Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt text to back button #465

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

CollinWoo
Copy link
Contributor

@CollinWoo CollinWoo commented Oct 2, 2023

Summary

This pull request adds alt text to the chevron button that takes users from the employee details page back to the employees list page.

image

  • Added alt text to the chevron image for the back button
  • Documented the compRides() function

Test Plan

Testing was conducted by using inspect element on the back button on the employee details webpage and verifying that the image has the alt attribute with the appropriate text:

Screenshot 2023-10-01 at 11 28 16 PM

@CollinWoo CollinWoo requested a review from a team as a code owner October 2, 2023 03:31
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 2, 2023

[diff-counting] Significant lines: 15.

Copy link
Member

@pratyush1712 pratyush1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding documentation! could you change the alt text from "Employees" to "Back to Employees List" because that makes more sense for the back buttton here. also, could you also make sure all the back buttons on the site has alt text (i think there might be more than just the employees button)

@pratyush1712 pratyush1712 merged commit 967cbf4 into master Oct 30, 2023
5 checks passed
@pratyush1712 pratyush1712 deleted the cww72/back-button-alt-text branch October 30, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants