Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total review counts and review counts per location on admin page #299

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

mluo24
Copy link
Contributor

@mluo24 mluo24 commented Sep 25, 2023

Summary

This PR adds counts for the total number of approved reviews on the platform, and it shows the number of reviews approved for each location (North, West, Collegetown, and Downtown).

Test Plan

image

I manually verified the counts by counting them in the UI.

Notes

Let me know if it's too ugly and I can change it.

@mluo24 mluo24 temporarily deployed to staging September 25, 2023 01:18 — with GitHub Actions Inactive
@mluo24 mluo24 changed the title Add total review counts and review counts per location Add total review counts and review counts per location on admin page Sep 25, 2023
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 66.

@mluo24 mluo24 changed the title Add total review counts and review counts per location on admin page Total review counts and review counts per location on admin page Sep 25, 2023
@mluo24 mluo24 requested a review from thuypham03 September 25, 2023 01:18
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Visit the preview URL for this PR (updated for commit d66d3ff):

https://cu-apts-staging--pr299-admin-review-counts-c80zw2kk.web.app

(expires Thu, 19 Oct 2023 15:36:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

Copy link
Contributor

@AnkitLakkapragada AnkitLakkapragada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks really good and is definitely much-needed information for us on the admin page! I like the separation of how you did it based on location to make it better for us to identify where we get our reviews from. When testing, everything seems to work right. Great work and looking forward to seeing this merged!

@cyrus14
Copy link
Contributor

cyrus14 commented Oct 2, 2023

Hey Miranda! This update looks awesome and it's exactly the kind of info we needed on the admin page. I really like how you've grouped it by location; it makes it super easy for us to see where our reviews are coming from. Testing it out, everything seems to be working smoothly. Great job, and I can't wait to see this added!

Copy link
Collaborator

@thuypham03 thuypham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR helps the team keeping track and monitor reviews' counts, which significantly contribute to our marketing and developing decision. Good job!

@thuypham03 thuypham03 temporarily deployed to staging October 12, 2023 15:33 — with GitHub Actions Inactive
@thuypham03 thuypham03 merged commit f2a39e0 into main Oct 12, 2023
6 checks passed
@thuypham03 thuypham03 deleted the admin-review-counts branch October 12, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants