Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to the ApartmentPage #301

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

AnkitLakkapragada
Copy link
Contributor

Summary

This pull request adds documentation to the ApartmentPage

Test Plan

None

Notes

Breaking Changes

None

@AnkitLakkapragada AnkitLakkapragada temporarily deployed to staging October 2, 2023 00:14 — with GitHub Actions Inactive
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 26.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Visit the preview URL for this PR (updated for commit e6f8985):

https://cu-apts-staging--pr301-documentation-apartm-o27kf3wo.web.app

(expires Thu, 19 Oct 2023 15:30:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

@ggsawatyanon
Copy link
Contributor

This documentation looks really thorough and well-written. Good job, Ankit!

Copy link
Collaborator

@thuypham03 thuypham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job in adding detailed param explanations.

@thuypham03 thuypham03 temporarily deployed to staging October 9, 2023 01:48 — with GitHub Actions Inactive
@thuypham03 thuypham03 temporarily deployed to staging October 12, 2023 15:28 — with GitHub Actions Inactive
@thuypham03 thuypham03 merged commit 462069d into main Oct 12, 2023
6 checks passed
@thuypham03 thuypham03 deleted the documentation-apartment-page branch October 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants